Files
claudemesh/apps/broker/tests/metrics.test.ts
Alejandro Gutiérrez 3458860c1f test(broker): coverage for hardening modules — caps, limits, metrics, health, logs
Adds 23 tests across 4 files, taking total broker coverage from
21 → 44 passing in ~2.5s.

Unit tests (no I/O):
- tests/rate-limit.test.ts (6): TokenBucket capacity, refill rate,
  no-overflow cap, independent buckets per key, sweep GC.
- tests/metrics.test.ts (5): all 10 series present in /metrics,
  counter increment semantics, labelled series produce distinct lines,
  gauge set overwrites, Prometheus format well-formed.
- tests/logging.test.ts (5): JSON per line, required fields (ts, level,
  component, msg), context merging, level preservation, no plain-text
  escape hatches.

Integration tests (spawn real broker subprocesses on random ports):
- tests/integration/health.test.ts (7):
  * GET /health 200 + {status, db, version, gitSha, uptime} (healthy DB)
  * GET /health 503 + {status:degraded, db:down} (unreachable DB)
  * GET /metrics 200 text/plain with all expected series
  * GET /nope → 404
  * POST /hook/set-status oversized body → 413
  * POST /hook/set-status 6th req/min → 429
  * Rate limit isolation by (pid, cwd) key

Integration tests use node:child_process (vitest runs under Node, not
Bun — Bun.spawn isn't available). Each suite spawns its own broker
subprocess with a random port + tailored env vars.

Not yet covered (flagged for follow-up):
- WebSocket connection caps (needs seeded mesh + WS client setup)
- WebSocket message-size rejection (ws.maxPayload behavior)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-04 22:19:14 +01:00

81 lines
2.9 KiB
TypeScript

/**
* Metrics output + counter/gauge behavior tests.
*
* Pure in-process — no DB, no network. Asserts Prometheus text
* format and counter/gauge increment semantics.
*/
import { beforeEach, describe, expect, test } from "vitest";
import { metrics, metricsToText } from "../src/metrics";
describe("metrics registry", () => {
test("every expected series is present in /metrics text", () => {
const text = metricsToText();
const expected = [
"broker_connections_total",
"broker_connections_rejected_total",
"broker_connections_active",
"broker_messages_routed_total",
"broker_messages_rejected_total",
"broker_queue_depth",
"broker_ttl_sweeps_total",
"broker_hook_requests_total",
"broker_hook_requests_rate_limited_total",
"broker_db_healthy",
];
for (const name of expected) {
expect(text).toContain(`# HELP ${name}`);
expect(text).toContain(`# TYPE ${name}`);
}
});
test("counter increments and appears in output", () => {
const before = metrics.connectionsTotal.toText();
const beforeVal = parseInt(
before.split("\n").find((l) => l.startsWith("broker_connections_total "))
?.split(" ")[1] ?? "0",
10,
);
metrics.connectionsTotal.inc();
metrics.connectionsTotal.inc();
const after = metrics.connectionsTotal.toText();
const afterVal = parseInt(
after.split("\n").find((l) => l.startsWith("broker_connections_total "))
?.split(" ")[1] ?? "0",
10,
);
expect(afterVal - beforeVal).toBeGreaterThanOrEqual(2);
});
test("counter labels produce separate series lines", () => {
metrics.messagesRoutedTotal.inc({ priority: "now" });
metrics.messagesRoutedTotal.inc({ priority: "now" });
metrics.messagesRoutedTotal.inc({ priority: "next" });
const text = metrics.messagesRoutedTotal.toText();
expect(text).toMatch(/broker_messages_routed_total\{priority="now"\}/);
expect(text).toMatch(/broker_messages_routed_total\{priority="next"\}/);
});
test("gauge set overwrites prior value", () => {
metrics.connectionsActive.set(5);
let text = metrics.connectionsActive.toText();
expect(text).toMatch(/broker_connections_active 5/);
metrics.connectionsActive.set(2);
text = metrics.connectionsActive.toText();
expect(text).toMatch(/broker_connections_active 2/);
expect(text).not.toMatch(/broker_connections_active 5/);
});
test("prometheus format is well-formed (HELP + TYPE before samples)", () => {
const text = metrics.queueDepth.toText();
const lines = text.split("\n");
expect(lines[0]).toMatch(/^# HELP broker_queue_depth /);
expect(lines[1]).toMatch(/^# TYPE broker_queue_depth gauge$/);
// Every non-comment line should be well-formed.
for (const line of lines.slice(2)) {
if (line.trim() === "") continue;
expect(line).toMatch(/^broker_queue_depth(\{[^}]*\})? -?\d+(\.\d+)?$/);
}
});
});